common

common copied to clipboard

`Login` and `Logout` API is missing unit tests

1

The API functions are not tested from what I can see: https://github.com/containers/common/blob/9d34b37ba77e370ac5efaef2a72820e82dcf804d/pkg/auth/auth.go#L66-L68 https://github.com/containers/common/blob/9d34b37ba77e370ac5efaef2a72820e82dcf804d/pkg/auth/auth.go#L204-L205 It also looks like that we use ginkgo/gomega based tests mixed with standard unit tests within the...

saschagrunert

Misleading messages when login/logout with docker-credential-pass

6

The messages printed when using `podman login/logout` are misleading. **Steps to reproduce**: The following steps assume that `docker-credential-pass` from https://github.com/docker/docker-credential-helpers is installed: 1. create `~/.config/containers/auth.json` containing: ``` { "credHelpers": {...

damienrg

fix(deps): update module github.com/containerd/containerd to v1.7.20

2

[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/containerd/containerd](https://togithub.com/containerd/containerd) | `v1.7.18` -> `v1.7.20` | [](https://docs.renovatebot.com/merge-confidence/)...

renovate[bot]

[skip-ci] RPM: move netavark deps to netavark package

9

iptables and nftables are best handled in netavark package. Ref: https://github.com/containers/netavark/pull/1033

lsm5

Use the WSL convention for the windows machines default volumes

9

Currently on Windows, volumes are mounted differently based on the provider: - WSL automatically mounts the main drive `C:/` under `/mnt/c` on every Linux VM - For HyperV instead, `podman`...

l0rd

libimage.Image: add ConvertToManifestList()

5

* Add `libimage.Image.ConvertToManifestList()`, which will convert an image to a manifest list if it isn't already possible to use it as one. * Tweak the godoc for the `libimage/manifests.AddArtifactOptions` type...

nalind

We use the linux bridge in VLAN-aware mode to interconnect different container/VMs (podman, libvirt, lxc, systemd-nspawn). To connect podman containers to a specific VLAN I use the CNI bridge plugin...

ahinrichs

New apparmor rules don't trigger a new profile unless upstream version is changed

2

When the apparmor template is changed, like was done recently to fix issue #1898 via PR #2004, the upstream version was not chagned, which means the [default apparmor profile name](https://github.com/containers/common/blob/116500d0a7b50f9d2cbf46b0c9ab543e22d844b8/pkg/apparmor/apparmor.go#L14)...

panlinux

[seccomp] update defaults to current docker rules (Started as: block unshare by default)

17

Hi, I've noticed that on my systems (fedora, debian, alpine) it's possible to get network admin privileges in a user namespace within a container: ``` $ podman run --rm -ti...

martinetd

AppArmor profile: recently added signal peers allow too much

5

In https://github.com/containers/common/commit/1aedc12e356cfd29a5bb54d94e9b2e09da3649ca you added the following signal rules to the AppArmor profile: ``` # Allow certain signals from OCI runtimes (podman, runc and crun) signal (receive) peer={/usr/bin/,/usr/sbin/,}runc, signal (receive) peer={/usr/bin/,/usr/sbin/,}crun*,...

cboltz