`Login` and `Logout` API is missing unit tests

Open saschagrunert opened this issue 4 years ago • 1 comments

The API functions are not tested from what I can see:

https://github.com/containers/common/blob/9d34b37ba77e370ac5efaef2a72820e82dcf804d/pkg/auth/auth.go#L66-L68

https://github.com/containers/common/blob/9d34b37ba77e370ac5efaef2a72820e82dcf804d/pkg/auth/auth.go#L204-L205

It also looks like that we use ginkgo/gomega based tests mixed with standard unit tests within the project, so I'm wondering which one you'd prefer.

Jul 05 '21 09:07 saschagrunert

No preference for which framework to use.

I guess that the two functions have not been tested so far since they are comparatively hard to test. CI is running inside a container and that makes it hard to run a local registry.

Jul 06 '21 08:07 vrothberg