Marko Milić comments

Results 20 comments of


                                            Marko Milić

override def getTransactions. No need for database lookups for params

@simonredfern Ready for testing.

check object BankMockAPI

No. We use only one case class from that code.

Add query parameters to GET Resource Docs

@simonredfern You removed TODO with this commit https://github.com/OpenBankProject/OBP-API/commit/1e3e40e44e96081e62de0cb18e97a41989be021d Please update or close the ticket

OAuth 1.0 -

@oscarAmarello Please take a look at this page: https://github.com/OpenBankProject/OBP-API/wiki/OAuth-1.0-Server#step-1--obtaining-a-request-token-

The client adds the protocol parameters to the request using the OAuth HTTP "Authorization" header field: Authorization: OAuth oauth_callback="http%3A%2F%2Fprinter.example.com%2Fready", oauth_consumer_key="cChZNFj6T5R0TigYB9yd1w", oauth_nonce="ea9ec8429b68d6b77cd5600adbbb0456", oauth_signature="F1Li3tvehgcraF8DMJ7OyxO4w9Y%3D", oauth_signature_method="HMAC-SHA256", oauth_timestamp="1318467427", oauth_version="1.0"

java.net.URISyntaxException: Illegal character in query

@sebtesobe `http://localhost:9200/_search?q=product_family:%22personal loans%22` has `space` in `url`. Do we need to use %20? i.e. `http://localhost:9200/_search?q=product_family:%22personal%20loans%22` has `space` in `url`

Add Resource UserAuthContext

State: - [x] Write GET endpoint - [x] Write POST endpoint - [ ] Write DELETE endpoint - [ ] Write tests - [x] separate by AKKA

Not UUID in create consumer page

Yes. Since version 3.1.0 we use UUID.

Path Parameters

Related issues: #692, #693, #694, #696, #697

Metrics. Use Akka / Kafka so we don't block whilst writing to metrics table.

Current state use a separate thread whilst writing to metrics table. It's fire and forget scenario. We can use Akka as the middleman in order to unify API for metrics.