conseilgouz
conseilgouz
AppVeyor failed because $this->version has correct values for Atom and RSS files. tests\Unit\Libraries\Cms\Feed\Parser\AtomParserTest.php file and tests\Unit\Libraries\Cms\Feed\Parser\RssParserTest.php seem to be wrong.
@richard67 : unit test files (RSS & ATOM) have been updated, so they match FeedFactory behaviour : go to root node and read it.
@richard67 : integration/drone/pr has a phpmin-system-postgress error : I'm afraid I don't have enough knowledge to fix this one....
After merging branch, postgress error disappeared...
@richard67 : about the changes, when initialise function is called in RssParser.php and AtomParser, stream (xmlreader) has read the root node : it's done in FeedFactory.php, function getFeed(), lines 68...
> but if nobody else can reproduce the issue I have doubts on this PR. That's a 4.2 RC1 issue. Let's hope somebody else will see this issue.
2 ways to fix #38310 1. update FeedFactory.php, so it does not read xml file before calling initialise function or 2. update RssParser & AtomParser so they assume actual xlm...
> i can replicate the issue like has been described It seems that just the two of us are interested in this issue.
@alikon : one more human test to go.....