Connor Tsui

Results 50 comments of Connor Tsui

I'm willing to make this PR and do some testing. But which of `IoSlice` and `IoSliceMut` should replace `libc::iovec`? Or should both be supported? The more obvious answer to me...

All that needs to change is this if we only accept `IoSliceMut`: ```rust pub unsafe fn register_buffers(&self, bufs: &[libc::iovec]) -> io::Result { // into pub unsafe fn register_buffers(&self, bufs: &[IoSliceMut

What was the reason why this was dropped? This seems like a good change...

Is there any plan to work on this? There seems to be a lot of additional features on top of basic code folding that would be interesting to have, but...

@SUPERCILEX Sorry for the delay. Here is my linux version: ``` ~ ❯ uname -r 6.8.7-arch1-1 ~ ❯ cat /etc/os-release NAME="Arch Linux" PRETTY_NAME="Arch Linux" ID=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://archlinux.org/" DOCUMENTATION_URL="https://wiki.archlinux.org/" SUPPORT_URL="https://bbs.archlinux.org/"...

Ah sorry one of them does not fail, specifically `msg.payload_data().is_empty()`. ```rust 0 => { let msg = msg.unwrap(); if !msg.is_payload_truncated() { println!("Payload is not truncated") } if !msg.is_name_data_truncated() { println!("Name...

@SUPERCILEX Output when commenting out the entire `match` statement + I added a `dbg!(i)` and `dbg!(msg.unwrap())`. It seems like the second branch with `i = 1` also trips some of...

I added a `dbg!(msg.unwrap());` ``` [io-uring-test/src/tests/net.rs:1544:21] i = 0 [io-uring-test/src/tests/net.rs:1547:21] msg.unwrap() = RecvMsgOut { header: io_uring_recvmsg_out { namelen: 16, controllen: 0, payloadlen: 15, flags: 32, }, msghdr_name_len: 4, name_data: [...

I had actually not read what the actual test was doing until just now, so I now have a few questions about this test. ```rust for (index, buf) in buffers.iter_mut().enumerate()...

Sorry for the delay, I've added a comment directly on the PR.