Connor

Results 97 comments of Connor

I can help testing the code on mac.

I plan to make multiple and chunked file uploads in one of my pilot project. At this moment I don't find any "official" direction about templating of UX modules (small...

You can do it with one more extra step: ``` steps: - uses: actions/checkout@v3 - name: Get Changed Files @ all id: all-changes uses: tj-actions/changed-files@v35 with: files: | lib/** tests/**...

Nothing is happening in 1.5.x at the moment, we are just following the latest php versions. This may remain the same, 1.5.x may be the recommended stable version. In various...

I forgot to write that I want to keep the interoperability between 1.5 and 1.6. Anyone using 1.5 under 8.2 should be able to switch to 1.6 at any time...

@thePanz master is the default branch. That fork was a mistake by the guy who made the fork. And I didn't think it would occur to anybody not to fork...

@thirsch Instead of master, we could also switch to the version branch in the 1.5.x branch. But we can delete it. :(

https://github.com/connorhu/symfony1/blob/feature/phpunit/tests/controller/sfWebControllerTest.php#L37-L51 sfWebControllerTest now fail because of type error. ``` yield ['module/action?id=12', array( '', array( 'module' => 'module', 'action' => 'action', 'id' => 12, ), )]; ``` : ``` --- Expected...

A copy from issue #285 PHPUnit brings up the errors nicely. The first assert fails because of an `acceptParameter` method bug. ``` $option = new sfCommandOption('foo', null, sfCommandOption::IS_ARRAY); $this->assertSame(true, $option->acceptParameter());...

Another "who made a mistake?" memo https://github.com/FriendsOfSymfony1/symfony1/blob/2826410bbfdb8dd69db968b9c44ca2550a38a9da/test/unit/routing/sfPatternRoutingTest.php#L546 Test message says: "->findRoute() returns **null** on non-matching route" The `findRoute` method calls `getRouteThatMatchesUrl` protected method. https://github.com/FriendsOfSymfony1/symfony1/blob/2826410bbfdb8dd69db968b9c44ca2550a38a9da/lib/routing/sfPatternRouting.class.php#L368-L411 https://github.com/FriendsOfSymfony1/symfony1/blob/2826410bbfdb8dd69db968b9c44ca2550a38a9da/lib/routing/sfPatternRouting.class.php#L474-L487 The `getRouteThatMatchesUrl` method returns `false`....