Connor Bär

Results 42 comments of Connor Bär

Good catch, @zeckdude! I think these code paths weren't reached in my testing, so the initial fix worked for my use case. Makes absolute sense to fix it everywhere though!

I no longer actively maintain this theme, but I'm open to PRs!

Fails again, even with `2.1.0`: https://travis-ci.org/sumup/circuit-ui/builds/559579687

I double-checked in the `yarn.lock` file and you're right, that was indeed `v2.2.0`. Interestingly though, the PR we thought that fixed it (by downgrading to `v2.1.0`) was _also_ using `v2.2.0`...

@ademers Are you going to try this? Otherwise I might give it a shot.

@ademers I've submitted a pull request (#10) already, just waiting for @khalwat to accept it. 😊

> We should also look into whether we can update our tsconfigs to point to an ES version above the current es2017. I did consider this when choosing the new...

I've gotten an initial confirmation from Giao Chung from the design team that this would fit well into their workflow and setup in Figma. I wanted to wait for feedback...

We're looking at this topic again as part of #871. @robinmetral was right to be concerned in his [last comment](https://github.com/sumup-oss/circuit-ui/issues/870#issuecomment-716556430), Diez hasn't had any new commits since August 2020 and...

Haha, I love your enthusiasm! ❤️ I can think of two approaches: 1. Implement the style changes on the component level, as you suggested. The `isDarkMode` setting could be part...