Craig Dunn

Results 21 comments of Craig Dunn

Hey @PureWeen I remember looking at this when we livestreamed, but it's still in draft. Do you think it's ready to merge or more work required?

@hartez only to prevent it accidentally being merged without someone taking a look at it... esp since the guidance suggested I target `main` branch but wasn't sure if it should...

Upon checking some other api doc PRs, they seem to target `main` so I'm changing this from Draft to Ready for review

Latest commits build a NuGet package in the **/artifacts/** folder (thanks to **Microsoft.Maui.Packages.slnf**), but I'm not sure the sample will be able to load it... ![image](https://user-images.githubusercontent.com/199373/165653678-a5e8b9b2-e8da-41a9-99a0-5c8fb2729d84.png)

Current error `D:\a\_work\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample.csproj : error NU1101: Unable to find package Microsoft.Maui.Controls.Foldable. No packages exist with this id in source(s): D:\a\_work\1\s\bin\dotnet\library-packs, darc-pub-dotnet-runtime-a21b9a2, dotnet-eng, dotnet-public, dotnet6, dotnet7, skiasharp [D:\a\_work\1\s\Microsoft.Maui.Samples.slnf]` There IS there...

It feels like what's happening on the server must be different to what's happening locally. Will probably roll-back these YAML changes that are trying to copy the **nupkg** around and...

The Foldable NuGet is definitely in the **nuget** artifact at the end! ![image](https://user-images.githubusercontent.com/199373/165976090-5443e55e-dbd3-4216-a80e-58257ac66f80.png)

@mattleibow yeah, that's why I was trying to copy the Foldable NuGet into `bin\dotnet\library-packs`, because it's already in the sources search list for the Samples project 😬 Still not sure...

I have not had a chance to test the NuGet. Will try to get it done today and approve if it works, thanks.

@rmarinho I started testing this today, but needed to rebuild my VS2022 config, workloads, etc as nothing initially worked. Will finish off tomorrow and let you know how it goes.