conan icon indicating copy to clipboard operation
conan copied to clipboard

Improve '.editorconfig' file

Open jgsogo opened this issue 5 years ago • 9 comments
trafficstars

image

jgsogo avatar Jul 16 '20 15:07 jgsogo

Hey! could you give some more insight into this? I'd like to make my first contribution. Can I work on this?

artorias111 avatar Sep 09 '20 13:09 artorias111

Sure, more than welcome. Thanks!

Consider modifying first the .editorconfig file in a PR and then we will eventually modify (step by step) all the files using it, do not make a PR modifying 2000 files 😄

Thanks!

jgsogo avatar Sep 09 '20 14:09 jgsogo

Yeah got it, thanks a lot!

artorias111 avatar Sep 09 '20 15:09 artorias111

Okay, so I need to put the line(s?)mentioned by @memsharded into the .editorconfig file and the make a pull request?

artorias111 avatar Sep 11 '20 02:09 artorias111

Yes @artorias111

The key here is to know what lines is necessary to put in .editorconfig that defines what to do with the multiple line indentation, I don't know if it is even possible.

I don't love the output of "black" formatter, but I am starting to consider it a possibility for Conan 2.0 codebase.

memsharded avatar Sep 11 '20 09:09 memsharded

Hey! I found this: https://github.com/editorconfig/editorconfig/issues/412 This seems to be a continuation_indent_size related issue. it appears the continuation_indent_size property is "domain-specific"(i.e. specific only to some languages, hence not implemented by the .editorconfig file), as stated here in the EditorConfig wiki: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties

artorias111 avatar Sep 20 '20 17:09 artorias111

Hi @artorias111

I have been playing with Pycharm, and it doesn't seem to support that editorconfig configuration. Then, I think we should just define some convention and try to attach to it.

I vote for using the default Pycharm one, which is extra indent the code, like:

if (something and 
        otherthing):
    do_something()

But lets use what the majority of maintainers want.

memsharded avatar Sep 20 '20 22:09 memsharded

Hello Everyone, Is this issue still active?

This issue looks beginner friendly, I'd like to contribute to this issue :)

CypherpunkSamurai avatar Sep 19 '22 20:09 CypherpunkSamurai

I think this is no longer active. It seems that we might considering using black after the migration to 2.0 ends, and we are no longer merging 1.X branches into 2.0.

memsharded avatar Sep 19 '22 21:09 memsharded