conan icon indicating copy to clipboard operation
conan copied to clipboard

[Meson] Meson appending user file names

Open franramirez688 opened this issue 3 years ago • 2 comments

Changelog: Feature: Meson build helper is listening to new configuration field tools.meson.mesontoolchain:user_filenames=["FILENAMES"] to append all the passed files to the list of the ones created by Conan. Docs: https://github.com/conan-io/docs/pull/XXXX Closes: https://github.com/conan-io/conan/issues/11961

franramirez688 avatar Sep 14 '22 14:09 franramirez688

From a documentation perspective, what is a meson "user filename"? Shouldn't this use a name more evocative of the fact that Meson calls them native machine files?

eli-schwartz avatar Sep 15 '22 01:09 eli-schwartz

From a documentation perspective, what is a meson "user filename"? Shouldn't this use a name more evocative of the fact that Meson calls them native machine files?

But there are native and cross files, right? Maybe something like tools.meson.mesontoolchain:additional_machine_files ?

lasote avatar Sep 15 '22 08:09 lasote

I am not convinced that the user story is injecting some meson files to all meson projects, or the users are missing a "local" way to inject those files inside package recipes, but like a different file for each project. I don't know enough about Meson usage and patterns, but we need to think about it.

I've changed the configuration name to tools.meson.mesontoolchain:extra_machine_files so I think it's more evident than before. In my opinion, the user story is if you want to add your own variables from any section to the existing Conan ones, so we don't need to add more public attributes to the MesonToolchain class interface to manage all the machine file sections.

franramirez688 avatar Oct 27 '22 11:10 franramirez688

From a documentation perspective, what is a meson "user filename"? Shouldn't this use a name more evocative of the fact that Meson calls them native machine files?

Changed to tools.meson.mesontoolchain:extra_machine_files. I think it's clear enough, doesn't it?

franramirez688 avatar Oct 27 '22 11:10 franramirez688