conan icon indicating copy to clipboard operation
conan copied to clipboard

xcodedeps: Fix dependency resolution if transitive dependencies have …

Open the-nic opened this issue 3 years ago • 3 comments
trafficstars

…components

When a dependency of a dependency would have components, only the default name conan_dep_dep.xconfig would be included. However, this file was never generated, as they are in the form conan_dep_component.xconfig.

Fix this by adding all components instead.

Also allow the components to have dashes and use _format_name() to avoid issues when parsing the xcconfig file.

Changelog: (Bugfix): XcodeDeps: Fix component handling in transitive dependencies Docs: https://github.com/conan-io/docs/pull/XXXX

  • [ ] Refer to the issue that supports this Pull Request.
  • [ ] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • [x] I've read the Contributing guide.
  • [x] I've followed the PEP8 style guides for Python code.
  • [ ] I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

the-nic avatar Aug 03 '22 16:08 the-nic

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 03 '22 16:08 CLAassistant

Hi @the-nic, Thanks a lot for the contribution. You are right, in that case it was not working correctly. I'm adding a test to confirm that these changes make it work as expected.

czoido avatar Aug 09 '22 11:08 czoido

Thanks a lot for the contribution. You are right, in that case it was not working correctly. I'm adding a test to confirm that these changes make it work as expected.

Thanks for the review and adding the test!

the-nic avatar Aug 09 '22 14:08 the-nic