conan icon indicating copy to clipboard operation
conan copied to clipboard

Published 20 hours ago • verified publisher icon conan-io

fix: Correct test

Open gabyx opened this issue 3 years ago • 3 comments
trafficstars

Changelog: (Bugfix): Fix the test TestConanFileSubfolder which should actually fail.

Issue: #11275

This test should be written like this, and will fail because the bug is not yet fixed. (if its a bug)

  • [x] Refer to the issue that supports this Pull Request.
  • [x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • [x] I've read the Contributing guide.
  • [x] I've followed the PEP8 style guides for Python code.
  • [x] I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

gabyx avatar Jul 05 '22 10:07 gabyx

This PR seems related too: https://github.com/conan-io/conan/pull/11556

memsharded avatar Jul 06 '22 06:07 memsharded

Hi @gabyx

This was assigned for 1.51, but we didn't get any response, so I am moving it to next iteration 1.52. Please check the above comments and let us know.

memsharded avatar Jul 27 '22 11:07 memsharded

@memsharded: Thanks, jeah I did not have time yet but I hope I can move the test.

gabyx avatar Jul 27 '22 18:07 gabyx

Hi @gabyx

This PR has been stale for a few months now, we have been moving it from release to release, I hope it is not an issue anymore, so I am closing it, many thanks for contributing! If you would like to re-open please do, and please have a look to the comments, specially the one to not change existing passing tests, but add new tests that capture the desired behavior.

memsharded avatar Oct 28 '22 11:10 memsharded