Michael Goulet comments

Results 300 comments of


                                            Michael Goulet

Use equality when relating formal and expected type in arg checking

@rustbot label +beta-nominated Fixes a beta regression https://github.com/rust-lang/rust/issues/130576 which was introduced by https://github.com/rust-lang/rust/pull/129059, but which i only caught in the crater run for https://github.com/rust-lang/rust/pull/129021#issuecomment-2297702647

(Anti-)regression between Rust 1.78.0 and Rust 1.79.0 with struct containing `Cow<[Self]>`

So I expect this code to compile, especially given that `Cow

Allow dropping `dyn Trait` principal

I'll let @lcnr do the judgement call of whether this needs a lang FCP or if types suffices. Thanks for picking this back up!

Update closures for edition 2021 disjoint closure capturing

> I think the only observable difference is the size of the closure value (though I'm not sure). Is that worth including? Definitely also affects auto traits.

WIP: Unstable impls

Could you please do a perf run before this lands too? The extra call to `hir_attrs` in `predicates_of` may need to be querifyied and/or some fast path might need to...

`#[derive(Default)]` on enum variants with fields

@estebank: Not sure why I got a ping directly lol, but this is blocked on coinduction which is blocked on the new trait solver.

Add lint against function pointer comparisons

If it's not too much work, could we do a crater run here to find out what kind of places are using this kind of comparison in the wild?

Add lint against function pointer comparisons

@bors try

Add lint against function pointer comparisons

@craterbot check

docs: autogenerate compiler flag stubs based on -Zhelp

@bors r+