Oleks V comments

Results 186 comments of


                                            Oleks V

Support sort merge join with a join condition

@viirya can I take it as I spent some time with SMJ?

Support sort merge join with a join condition

Thanks @andygrove I'll take if from now

Support sort merge join with a join condition

Waiting for DataFusion 44.0.0

feat: Make spark builtin expression coverage report more readable

This comment can also be included https://github.com/apache/arrow-datafusion-comet/pull/263#discussion_r1569832400 from @advancedxy

[EPIC] Add Spark expression coverage

The list of Spark expression can be found https://spark.apache.org/docs/latest/api/sql/index.html

[EPIC] Add Spark expression coverage

I was thinking to add Spark `Scan OneRowRelation` scan support in addition to Parquet Scan. This will allow Comet be enabled when running queries like ``` select sqrt(2) from (select...

[EPIC] Add Spark expression coverage

Another potential solution we can do is to transform OneRowRelation and to use DF `PlaceholderRowExec`. I'll check if its doable

[EPIC] Add Spark expression coverage

I have an idea to do that. Planning to create a draft soon. Basic idea is to grab queries from https://spark.apache.org/docs/latest/api/sql/index.html and create a separate task in Comet which will...

[EPIC] Add Spark expression coverage

> > Basic idea is to grab queries from https://spark.apache.org/docs/latest/api/sql/index.html and create a separate task in Comet which will check if the Comet being triggered. > > Hmmm, I think...

Switch to stable Rust

For `int_roundings` there is a thread to make it partially stable https://github.com/rust-lang/rust/issues/88581