Oleks V comments

Results 60 comments of


                                            Oleks V

Ballista assumes all aggregate expressions are not DISTINCT

Hi @andygrove Ive run in local ballista ``` SELECT count(distinct c1) as cnt_distinct FROM aggregate_test_100 ``` And the result is expected ``` +--------------+ | cnt_distinct | +--------------+ | 5 |...

Ballista assumes all aggregate expressions are not DISTINCT

I checked the backtrace ``` 2: datafusion_physical_expr::aggregate::build_in::create_aggregate_expr at ./datafusion/physical-expr/src/aggregate/build_in.rs:75:13 3: datafusion::physical_plan::planner::create_aggregate_expr_with_name at ./datafusion/core/src/physical_plan/planner.rs:1347:13 4: datafusion::physical_plan::planner::create_aggregate_expr at ./datafusion/core/src/physical_plan/planner.rs:1390:5 5: datafusion::physical_plan::planner::DefaultPhysicalPlanner::create_initial_plan::{{closure}}::{{closure}} at ./datafusion/core/src/physical_plan/planner.rs:525:29 ``` sounds weird, but I didn't notice ballista modules...

Ballista assumes all aggregate expressions are not DISTINCT

> > Hi @andygrove Ive run in local ballista > > The issue is specific to distributed mode because it is the serde that has the hard-coded value Is there...

Make Query result limit value configurable instead of hardcoded 500 to reduce roundtrips to support also queries returning dozens of thousands rows with a few columns

@patricker I moved that config value to optionManager

`array[]` / `make_array()` will error if the types can not be coerced to a common type

@alamb this issue description confronts with #3123 Which one should be done?

`array[]` / `make_array()` will error if the types can not be coerced to a common type

@alamb I checked 3 options ``` DataFusion CLI v11.0.0 ❯ select make_array(1,2,'3'); +----------------------------------------+ | makearray(Int64(1),Int64(2),Utf8("3")) | +----------------------------------------+ | [1, 2, 3] | +----------------------------------------+ 1 row in set. Query took 0.006...