Oleks V comments

Results 60 comments of


                                            Oleks V

Implement IGNORE NULLS for window functions

Nice, everything is done, so closing it. thanks @mustafasrepo @huaxingao @viirya @alamb @ozankabak

[EPIC] Additional Date/Time related open issues

oh wow, thanks @alamb

idea: add another `static_name()` method to `ExecutionPlan` trait

Thanks @waynexia could you please give an example how the static be called for different plan nodes to obtain different names?

regression: `BigDecimal::from_str` gives unexpected result

@akubera any updates ?

Fix: Sort Merge Join LeftSemi issues when JoinFilter is set

I was able to fix initial query but now stuck on ``` Error: ArrowError(InvalidArgumentError("all columns in a record batch must have the same length"), None) ``` Likely related to nulls

Fix: Sort Merge Join LeftSemi issues when JoinFilter is set

fuzztests failing...

Fix: Sort Merge Join LeftSemi issues when JoinFilter is set

@viirya @alamb can I get a review on this PR please?

Fix: Sort Merge Join LeftSemi issues when JoinFilter is set

Thanks @alamb I'll add more docs and also added a task to check RightSemi join to https://github.com/apache/datafusion/issues/9846 I'll let it be opened a little longer to give @viirya more time...

Fix: Sort Merge Join LeftSemi issues when JoinFilter is set

@viirya I'm planning to merge this PR soon as it fixes the crash, and addresses your concern (please see the slt test covering this specific case). All other improvements can...

Fix: Sort Merge Join LeftSemi issues when JoinFilter is set

> I've seen some issues in this patch. It doesn't look like a correct fix. The tests currently in sync with what hash join returns, is there a test showing...