Oleks V comments

Results 186 comments of


                                            Oleks V

Fix: Map functions crash on out of bounds cases

> @comphead, can you please tell if there is something I can do to move this forward? Are there any relevant benches I could either run or adapt for this...

Fix: Map functions crash on out of bounds cases

Closing in favor of #16802

chore(deps): bump lz4_flex from 0.11.5 to 0.12.0 in /native

@dependabot rebase

fix: Support scalar/array args for rpad/read_side_padding

@coderfender as were working on rpad/lpad

fix: Throws an exception when struct type has duplicate keys

@wForget will this PR close also https://github.com/apache/datafusion-comet/issues/2256

Add hook for sharing join state in distributed execution

@korowa FYI

Add hook for sharing join state in distributed execution

Maybe its easier to build some diagram in draw.io or something? I got the point about shared state but I'm not sure how it will be travelling from caller side...

Make modulos with negative float zero compat with other engines

> I don't have a strong preference one way or the other, personally I would go with Spark/DuckDB way :) if there is no other strong opinions, I'll make a...

Make modulos with negative float zero compat with other engines

Thanks @parthchandra for the suggestion, I just checked we should be fine. ``` scala> spark.sql("select 1 % -0.0").show(false) +---------+ |(1 % 0.0)| +---------+ |NULL | +---------+ scala> spark.sql("select isnan(1 %...

Make modulos with negative float zero compat with other engines

This is a good point @jonahgao so this gives me even more confidence to introduce a new DF param which controls should DF go with IEEE 754