compf

Results 11 comments of compf

> @compf Thanks a lot for your contribution. It is an interesting innovation project and idea to apply LLM to improve our project code quality. I have the following questions:...

> Thanks for the contribution. I am a little doubtful on this refactoring. It creates a new very abstract class `OperationParameters`, that is just a container of two abstract maps....

Thank you very much for the feedback. I will certainly cite Jabref. Somehow my Checkstyle was buggy so it didn't spot these formatting issues. After reinstalling, it worked

> Some more comments :) > > I think, I should re-do the survey. The LLM is very bad in keeping `@param` comments. I, formyself, understood it now: > >...

Oh, I totally forgot. I will finish the pull request by the end of this week if that's ok :)

Thank you very much for the feedback. I can apply your feedback by the end of this week if this is ok :)

@MalloD12 In have simplified the DataBaseTableIdentifier class as suggested. According to the email notification, You have written more comments but they seem to be deleted or I can't find them...

> Thanks for your contribution! Use of LLM is indeed very useful. The creation of `RectangleCoordinates` is a good point. However, I would probably set the class as immutable (that...

> What is common to all classes were you added the ProcessProperties is that they inherit from UnixProcess. So instead adding a new class just for the properties wouldn't it...

Thank you very much for the feedback. @daniel-beck You are correct that your proposal is better. I haven't encountered this corner case where fields are shared in derived classes before...