chenglei

Results 6 comments of chenglei

@liangxs ,would you please fix the spotless error?

@Apache9 ,thank you very much for point this out, yes, but the current `FSHLog.RingBufferEventHandler.onEvent` which called `FSHLog.append` also have the same problem you described and may also block the single-thread...

@Apache9 , after I read the `FSHLog` code in current master, 2.x, 1.x and 0.98, I find there are always existing a single-thread consumer to call blocking `ProtobufLog.append`(eg. in master...

@Apache9 , would you mind review the comments again and give some suggestions at your convenience ?

@Apache9 , ok ,I will try to keep the changes within the FSHLog.

@Apache9 , thank you for review and very sorry for later response, the approach is somewhat straightforward, `AsyncFSWAL` uses `consumeLock` to synchronize operations between `AsyncFSWAL.consumeExecutor` and `AsyncFSWAL.doReplaceWriter` (also `AsyncFSWAL.doShutdown`), I...