panda icon indicating copy to clipboard operation
panda copied to clipboard

Hongqi HS5

Open jyoung8607 opened this issue 3 years ago • 4 comments

Work in progress, mostly there. TODO:

  • [ ] CC button (set/resume and cancel button handling), need to work this out in opendbc first
  • [ ] verify ABS wheel speed signal scaling, current value is approximated
  • [ ] confirm driver input torque threshold is reasonable
  • [ ] explore factory EPS limits
  • [ ] replay route

This passes CI testing locally, but won't pass in GitHub CI until the opendbc PR is merged and bumped in openpilot.

jyoung8607 avatar Mar 21 '22 09:03 jyoung8607

@robbederks @briskspirit It looks like part of the H7/Red Panda memory map is on the fine edge of overflowing. I've started having problems building this PR. Everything seems fine if I comment out a couple other unrelated safety modes. I don't know what happens if the H7 memory map is modified, or if it's even possible to modify.

https://github.com/commaai/panda/blob/f56ebf5b776b677bf12ec772b0223274dd798999/board/stm32h7/stm32h7x5_flash.ld#L64-L73.

image

jyoung8607 avatar Oct 22 '22 22:10 jyoung8607

Will increase memory available size on Monday

briskspirit avatar Oct 22 '22 23:10 briskspirit

Should be fixed on master, "freed" ~28Kb

briskspirit avatar Oct 26 '22 04:10 briskspirit

Should be fixed on master, "freed" ~28Kb

Looks good now, thank you!

jyoung8607 avatar Oct 31 '22 18:10 jyoung8607