panda icon indicating copy to clipboard operation
panda copied to clipboard
verified publisher icon commaai

Defining types in return dictionaries

Open MarinkoMagla opened this issue 1 year ago • 4 comments

It was under "TODO" in python/ccp.py to define types for couple of function returns.

MarinkoMagla avatar Apr 02 '24 07:04 MarinkoMagla

Hi @adeebshihadeh, can you take another look on this?

MarinkoMagla avatar May 08 '24 10:05 MarinkoMagla

This comment still applies https://github.com/commaai/panda/pull/1923#discussion_r1552267692

adeebshihadeh avatar May 08 '24 17:05 adeebshihadeh

Linter is still failing

adeebshihadeh avatar May 12 '24 17:05 adeebshihadeh

Hi @adeebshihadeh, linter is ok now, can you take another look?

MarinkoMagla avatar Jun 10 '24 08:06 MarinkoMagla