panda icon indicating copy to clipboard operation
panda copied to clipboard
verified publisher icon commaai

Hyundai: Car Port for Nexo 2021

Open sunnyhaibin opened this issue 2 years ago • 4 comments

Prerequisite of

  • https://github.com/commaai/opendbc/pull/933

sunnyhaibin avatar Sep 04 '23 15:09 sunnyhaibin

  • [ ] Needs tests

sshane avatar Nov 02 '23 21:11 sshane

Looks reasonable at a glance, but as Shane mentioned, will need a test added. That's why CI isn't passing, because the FCEV code path isn't exercised at all.

Unite test updated and all passed.

sunnyhaibin avatar Sep 25 '24 03:09 sunnyhaibin

Awaiting test route from user simon402_61863 (Discord).

sunnyhaibin avatar Sep 25 '24 05:09 sunnyhaibin

The actual code here is GTM, but the original public test route has gone away, and we shouldn't merge this component without an immediate path to merging the opendbc port.

jyoung8607 avatar Sep 25 '24 05:09 jyoung8607