IsoTpMessage: support ISO-TP w/ CAN FD

[sshane]

very much a draft just to make it work, wanted to have a CAN FD user test.

[coffee-cake-isaac]

Working on my F150 Lightning fork as well.

[blue-genie]

I have been running with this change in this PR, as is, for a few weeks - it fingerprints correctly every time - 2023 F-150 ICE

[sheaduncan]

@adeebshihadeh we have a lot of users on the Ford CAN-FD test branch that @coffee-cake-isaac created and continue to see successful fingerprints using this fix.

[sheaduncan]

@sshane, this is working for C3X users. However, we do have one Mach-E user who missed a FP and was returning Mazda ECUs.

This UDS fix works to get all the responses, but there may need to be some work on the FW version query on the OP side.

These VEHICLE_MANUFACTURER_ECU_SOFTWARE_NUMBER seemed to be shared between Ford and Mazda

[coffee-cake-isaac]

Also seem to have a bit of an issue with some HKG users no longer fingerprinting properly, either.

[sshane]

@coffee-cake-isaac what is the issue related to HKG?

[sshane]

@sshane, this is working for C3X users. However, we do have one Mach-E user who missed a FP and was returning Mazda ECUs.

This UDS fix works to get all the responses, but there may need to be some work on the FW version query on the OP side.

These VEHICLE_MANUFACTURER_ECU_SOFTWARE_NUMBER seemed to be shared between Ford and Mazda

Do you have a dongle ID for that user?

[coffee-cake-isaac]

@coffee-cake-isaac what is the issue related to HKG?

I don't actually know if this was related or not; Sunny's users were having issues when introducing this with Sunnypilot, but I think it was unrelated as we haven't heard anything since.

EDIT: I just confirmed this is still in SP and we haven't had fingerprint issues aside from the overlapping ones like myself and another Mach E have experienced.

[coffee-cake-isaac]

@sshane, this is working for C3X users. However, we do have one Mach-E user who missed a FP and was returning Mazda ECUs. This UDS fix works to get all the responses, but there may need to be some work on the FW version query on the OP side. These VEHICLE_MANUFACTURER_ECU_SOFTWARE_NUMBER seemed to be shared between Ford and Mazda

Do you have a dongle ID for that user?

Actually, since I've had some ECU upgrades done for a recall mine is doing it now, as well. Since most of my routes recently have been on a fork without this panda change, I have a route that shows this as well.

112e4d6e0cad05e1|2024-01-03--12-11-40

[sheaduncan]

@sshane, this is working for C3X users. However, we do have one Mach-E user who missed a FP and was returning Mazda ECUs. This UDS fix works to get all the responses, but there may need to be some work on the FW version query on the OP side. ![image](https://private-user-images.githubusercontent.com/22713956/291014423-74d2d196-0821-4bc6-b87b-69321aa7bc04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY2MjI4ODYsIm5iZiI6MTcwNjYyMjU4NiwicGF0aCI6Ii8yMjcxMzk1Ni8yOTEwMTQ0MjMtNzRkMmQxOTYtMDgyMS00YmM2LWI4N2ItNjkzMjFhYTdiYzA0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTMwVDEzNDk0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU3OGM4OWRlNTIzMzc5YThlOTllYzU5MDI1NTdlZTdhZmE2NjVkNDVlYzQ1ZmEyZTEwZTY3Njg0OGFkOTljODUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N

@sshane, this is working for C3X users. However, we do have one Mach-E user who missed a FP and was returning Mazda ECUs. This UDS fix works to get all the responses, but there may need to be some work on the FW version query on the OP side. These VEHICLE_MANUFACTURER_ECU_SOFTWARE_NUMBER seemed to be shared between Ford and Mazda

Do you have a dongle ID for that user?

83a4e056c7072678

[sshane]

112e4d6e0cad05e1|2024-01-03--12-11-40

That route looks fine as long as we get everything back from the Ford queries, if ECUs happen to respond to Mazda queries, that's okay

Edit: same with 83a4e056c7072678, EPS responds to both ford and mazda so during fingerprinting it will only look at Mazda

[sheaduncan]

112e4d6e0cad05e1|2024-01-03--12-11-40

That route looks fine as long as we get everything back from the Ford queries, if ECUs happen to respond to Mazda queries, that's okay

Edit: same with 83a4e056c7072678, EPS responds to both ford and mazda so during fingerprinting it will only look at Mazda

Strange, not sure why they're failing to fingerprint then. Those FW versions are in Ford's listed FW versions.

[coffee-cake-isaac]

Yeah, they all come back but it says "Car Unrecognized".

[sshane]

Which route? All recent mock routes (not many) for 83a4e056c7072678 fingerprint on master.

[sheaduncan]

What's needed to help get this PR merged?

[northportio]

status update?

[sshane]

When we officially support CAN FD Ford (we are looking into a vehicle to purchase), we will put the time into verifying and merging this!