openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Car Port: Kia Carnival HEV 2025 (HDA2)

Open ccdunder opened this issue 1 year ago • 4 comments

Checklist

  • [X] added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [x] test route added to routes.py
  • [X] route with openpilot: 6c0069dcd5bbb6c1/00000020--6b95507969
  • [X] route with stock system: 6c0069dcd5bbb6c1/00000021--e6c25dde2d
  • [X] car harness used (if comma doesn't sell it, put N/A): Hyundai Q

Dependencies:

  • https://github.com/commaai/panda/pull/2109
  • https://github.com/commaai/opendbc/pull/1580

Relation to #34163: I don't believe this is a dupe. Happy to chat further if there are questions or concerns.

At the time this was opened,

  1. This code is novel, doesn't duplicate or overlap.
  2. This car is novel (HEV, first year).
  3. This code was developed independently.
    • I id'd the harness using schematics, and pulled fingerprints from my own car. Then I fixed issues.
  4. #_34163 hadn't moved in over a week.

ccdunder avatar Dec 14 '24 23:12 ccdunder

This PR is a duplicate of https://github.com/commaai/openpilot/pull/34163.

sunnyhaibin avatar Dec 15 '24 15:12 sunnyhaibin

This PR is a duplicate of #34163.

I've updated the description to address this.

ccdunder avatar Dec 15 '24 19:12 ccdunder

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Dec 27 '24 02:12 github-actions[bot]

This is still open and ready for review.

ccdunder avatar Dec 28 '24 22:12 ccdunder

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Jan 08 '25 02:01 github-actions[bot]

Still open

ccdunder avatar Jan 08 '25 22:01 ccdunder

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Jan 19 '25 02:01 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Jan 22 '25 01:01 github-actions[bot]

This is alive and well.

ccdunder avatar Jan 23 '25 20:01 ccdunder