commaai
Enable OP w/ brakeHold active
Are you sure this works for all car brands? Hyundai does not allow you to engage SCC if brake hold is active.
This is also not the correct way to introduce allowing brake hold to transition openpilot to enabled:
- No longer disables openpilot when entering brake hold active
- Fails the unit tests as it triggers panda safety violations
I believe folks at Comma are testing this on different car models. I believe after that batch of testing, recommendations will be made on how to proceed. You're definitely right, this will need further changes in structure to work.
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.