openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Toyota: verify start from stop change

Open sshane opened this issue 1 year ago • 2 comments

Verify the change in https://github.com/commaai/openpilot/pull/33974.

Check for no insane overshoot on most of the TSS2 platforms:

  • [ ] TOYOTA_AVALON_TSS2
  • [ ] TOYOTA_CAMRY_TSS2
  • [x] TOYOTA_CAMRY_TSS2 (hybrid): https://connect.comma.ai/6483a59cd49b6650/00000063--9c50578243/333/347
  • [x] ~TOYOTA_SIENNA_4TH_GEN~
  • [ ] LEXUS_IS_TSS2
  • [ ] LEXUS_RX_TSS2
  • [ ] LEXUS_NX_TSS2
  • [ ] TOYOTA_HIGHLANDER_TSS2
  • [x] TOYOTA_COROLLA_TSS2: https://commaai.github.io/opendbc-data/longitudinal_reports/TOYOTA_COROLLA_TSS2_a2bddce0b6747e10_000003a9--cbb0f4bdcc.html
  • [x] TOYOTA_COROLLA_TSS2 (hybrid): 075b133b6181e058/000000a8--85b7b1353f & https://commaai.github.io/opendbc-data/longitudinal_reports/TOYOTA_COROLLA_TSS2_c16896da5621b481_00000005--224246799e.html
  • [ ] LEXUS_LC_TSS2
  • [ ] TOYOTA_RAV4_TSS2_2023
  • [ ] TOYOTA_RAV4_TSS2_2022
  • [x] LEXUS_ES_TSS2: https://commaai.github.io/opendbc-data/longitudinal_reports/LEXUS_ES_TSS2_57048cfce01d9625_00000208--c387e67187.html
  • [ ] TOYOTA_RAV4_TSS2
  • [x] TOYOTA_PRIUS_TSS2: 1d5211a9795b6ec2/00000384--e76f596e84
  • [ ] TOYOTA_MIRAI
  • [x] ~TOYOTA_RAV4_PRIME~
  • [ ] TOYOTA_ALPHARD_TSS2
  • [ ] TOYOTA_CHR_TSS2

sshane avatar Nov 09 '24 05:11 sshane

Hi @sshane . I still having problem with new long. Please check my drive. 4ffdd3a6a974b54b/00000003--9a2ea7cda2/11 My car is Corolla TSS2 Hybrid EU.

image

Overshooting 4ffdd3a6a974b54b/00000009--7eb0cd2de3/11

image

I have lot of example.

devimauz avatar Nov 18 '24 00:11 devimauz

Thanks for the feedback, but this issue is only for the start from stop change we recently made. Braking should still overshoot until I merge https://github.com/commaai/opendbc/pull/1499

sshane avatar Nov 18 '24 02:11 sshane

Haven't seen any bad cases/reports!

sshane avatar Jan 14 '25 22:01 sshane

Haven't seen any bad cases/reports!

how many bad report should i do?

devimauz avatar Jan 14 '25 22:01 devimauz

This issue is about start from stop. We also merged some braking overshoot prevention last month, please provide a route on the latest version of master with issues and I can take a look

sshane avatar Jan 14 '25 22:01 sshane