openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

ui/model: use height from LiveCalibration instead of hardcoded offset Z

Open deanlee opened this issue 1 year ago • 3 comments

~Replaced hardcoded Z-offsets with PATH_OFFSET_Z to ensure consistent Z-offset usage for both the lead and path, improving visual clarity.~ updated. use height from LiveCalibration

deanlee avatar Oct 16 '24 05:10 deanlee

UI Preview

onroad : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_disengaged : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_override : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_sidebar : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_wide : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_wide_sidebar : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_alert_small : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_alert_mid : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_alert_full : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

github-actions[bot] avatar Oct 16 '24 05:10 github-actions[bot]

Separate from your work, I think the static value makes the path appear noticeably different on short vs tall cars.

@YassineYousfi could liveCalibration.height[0] serve to replace this constant?

jyoung8607 avatar Oct 16 '24 18:10 jyoung8607

Yes it could be used for this purpose

YassineYousfi avatar Oct 17 '24 20:10 YassineYousfi