openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

op sim: fix car steering angle

Open sshane opened this issue 1 year ago • 5 comments

selfdrived always is adding the turn exceeded warning without this

before: image

after: image

sshane avatar Oct 03 '24 21:10 sshane

This adds some weird "swirling" when turning:

https://github.com/user-attachments/assets/c2d1cda8-4011-4343-8c5f-97b69ce832f3

maxime-desroches avatar Oct 03 '24 21:10 maxime-desroches

This is because liveParameters is learning the offset ~equivelent to the angle. Also noticed the lateral control type is also set to torque despite the simulator being an angle car.

sshane avatar Oct 03 '24 21:10 sshane

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Oct 13 '24 02:10 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Oct 16 '24 02:10 github-actions[bot]

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Oct 27 '24 02:10 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Oct 30 '24 02:10 github-actions[bot]