openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard
verified publisher icon commaai

Simple AEB

Open adeebshihadeh opened this issue 1 year ago • 6 comments

  • [ ] trigger with left blinker
  • [ ] abstractions
  • [ ] Toyota first?
  • [ ] gate behind a debug param

open questions

  • [ ] CC.longActive = True for AEB?

adeebshihadeh avatar Sep 10 '24 23:09 adeebshihadeh

longActive being true sounds confusing, you don't want to accidentally leave it on and transition into normal ACC. Maybe we need a longState (=off, on, aeb), or is that more confusing?

sshane avatar Sep 11 '24 02:09 sshane

 CC.longActive = True for AEB?

Probably not. At least some different active state. For AEB you need to a) go active spontaneously when the user hasn't explicitly engaged, and b) continue actuating with driver braking (preexisting or rising edge) or even opposing driver gas (probably preexisting only). These are all completely antithetical to the existing safety model and would make conventional ACC safety hopelessly untestable spaghetti.

jyoung8607 avatar Sep 11 '24 03:09 jyoung8607

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Sep 22 '24 02:09 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Sep 25 '24 02:09 github-actions[bot]

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Oct 05 '24 01:10 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Oct 07 '24 02:10 github-actions[bot]