openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

replay: add support for dcecompressing ZST log files

Open deanlee opened this issue 1 year ago • 1 comments

deanlee avatar Jul 05 '24 05:07 deanlee

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Jul 05 '24 05:07 github-actions[bot]

@deanlee we're getting this merged soon, is this good to go?

sshane avatar Jul 26 '24 06:07 sshane

Yes, I've tested it and it's ready to go. However, there is still an issue with the selfdrive/PR comments. It can't find #include <zstd.h>. It seems we need to update the Docker image to include the zstd library. Do you have any ideas on how to resolve this?

deanlee avatar Jul 26 '24 07:07 deanlee

Looks like it's building the docker image from the base branch, which is expected to fail here. Hopefully we can clean up this job very soon, but I wouldn't make it a blocker for this PR. It should pass once we merge.

sshane avatar Jul 27 '24 00:07 sshane

The PR is ready, suggested changes have been applied.

deanlee avatar Jul 27 '24 05:07 deanlee

ty!

sshane avatar Jul 29 '24 20:07 sshane