commaai
Add Honda Odyssey 2023
Car 2023 Honda Odyssey
Route d7233a428eb7d0b5/00000017--11cdf651c0
Special thanks to @csouers, his attempt has helped a lot.
Thanks a bunch to @jyoung8607 for invaluable support on this PR.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Comma, please upload route d7233a428eb7d0b5/00000005--4540b82b5b to CI store.
You'll need to upload the rlogs for that route first.
If this means Log Upload from connect portal, then I just did that.
Potential issue discovered: miles on the route number reported on useradmin portal to are too much for the route. I drove for 25 minutes, I doubt I could really do 53 miles in that time in 2023 Honda Odyssey during weekday morning. Actual distance is far less. I wonder how is that calculated and if these car values somehow affect miles counter.
The only failing check is
Route not on CI bucket. This is fine to fail for WIP car ports, just let us know and we can upload your routes to the CI bucket.
Please add test route d7233a428eb7d0b5/00000017--11cdf651c0 to the CI bucket
There is a lot of code missing from the 2021-22 port: https://github.com/commaai/openpilot/pull/25450 @csouers do you know if we need it still/any new discoveries made to simplify the port?
There is a lot of code missing from the 2021-22 port: #25450 @csouers do you know if we need it still/any new discoveries made to simplify the port?
@sshane I did work on simplifying/breaking apart the changes, then got distracted. This pr looks to be a good base to build upon for changes like supporting variable minsteer enable/disable speeds.
One important thing that I feel should be implementing is better alerting for when steering control is being filtered by the radar. Common scenarios like disabling steering due to low speed and lo/hi wiper mode aren't communicated to the user. The stock LKAS limitations are implemented in the radar's firmware and still apply with OP doing lateral-only. Can compare OP's internal lateral state with the radar's or EPS' for this. Note that the EPS will not report fault for this.
A basic low steer speed alert isn't yet implemented for Honda so the system can appear to be fully engaged when it's really not. I have a branch related to this that I'll refresh.
@csouers I found a flag we can use to detect when steering is filtered. However, I'm interested in what you are saying about wipers. Just today this branch was steering me through rain with wipers on high, no problem at all. OP was more comfortable than me, steering was working the same as with wipers off.
Oh cool. That's good to know. I've seen drives on the earlier models where it would consistently disengage. I'm surprised Honda would have made that change.
We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.
PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject
Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.