GWM: Haval h6 2024
*****CarBrand Port *****
Development Checklist
- [x] Use toyota corolla tss2 as a base
- [ ] Try made openpilot react a safety signals:
- [x] BrakePressed
- [x] WheelSpeed
- [ ] GasPressed
- [ ] SeatBelt unlatched
- [ ] DoorOpen
- [ ] Gears
- [ ] ParkBrake
- [ ] SteerPressed
- [ ] start GWM interface from scratch
- [ ] clean all toyota and other development state modifications, keep openpilot in a clean state
- [ ] Test again all safety and start panda safety
- [ ] figure out CRC
- [ ] try control steer
- [ ] try control longitudinal
- [ ] keep all existing tests working
- [ ] need new test?
working togheter https://github.com/celobusana requires: https://github.com/commaai/opendbc/pull/1038
crc algorithm ? https://github.com/commaai/openpilot/pull/32877/files
Final Checklist
- [ ] added entry to CAR in selfdrive/car/*/values.py and ran
selfdrive/car/docs.pyto generate new docs - [ ] test route added to routes.py
- [ ] route with openpilot:
- [ ] route with stock system:
- [ ] car harness used (if comma doesn't sell it, put N/A): N/A (Haval h6 "GT" needs a different harness from h6)
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.
PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject
Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.