openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Hyundai longitudinal (CAN): don't send `FCA12` on non-FCA cars

Open sunnyhaibin opened this issue 1 year ago • 1 comments

Description

  • Added int flag USE_FCA12. Some platforms such as the GENESIS_G80 do not have both FCA11 and FCA12. This PR introduces a new int flag that conditionally checks if FCA12 exists on the CAN bus. If FCA12 does not exist, we do not try to send FCA12 when openpilot longitudinal control is enabled.
  • Renamed int flag USE_FCA --> USE_FCA11

Verification

  • openpilot Longitudinal Control (Alpha) engaged successfully on the GENESIS_G80, which does not have FCA11 and FCA12.

Route

  • Route: fc0b0898f920f030/00000001--ab82eecd02

Prerequisite of

  • https://github.com/commaai/openpilot/pull/32580

Thanks to community 2018 Genesis G80 owner gogrant43 (Discord).

sunnyhaibin avatar May 31 '24 02:05 sunnyhaibin

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar May 31 '24 02:05 github-actions[bot]

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

sshane avatar Aug 20 '24 06:08 sshane