Hyundai longitudinal (CAN): don't send `FCA12` on non-FCA cars
Description
- Added int flag
USE_FCA12. Some platforms such as theGENESIS_G80do not have bothFCA11andFCA12. This PR introduces a new int flag that conditionally checks ifFCA12exists on the CAN bus. IfFCA12does not exist, we do not try to sendFCA12when openpilot longitudinal control is enabled. - Renamed int flag
USE_FCA-->USE_FCA11
Verification
openpilot Longitudinal Control (Alpha)engaged successfully on theGENESIS_G80, which does not haveFCA11andFCA12.
Route
- Route:
fc0b0898f920f030/00000001--ab82eecd02
Prerequisite of
- https://github.com/commaai/openpilot/pull/32580
Thanks to community 2018 Genesis G80 owner gogrant43 (Discord).
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.
PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject
Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.