VW MQB: Add FW for 2022 CUPRA Ateca
Car
2022 CUPRA Ateca. Expand supported model years, and add the CUPRA brand separately from SEAT.
Thanks to community Ateca owner Ziggehh!
Route
6669047569f87e35/00000007--1ab381bc79
Additional Info
I expected this to VIN fingerprint after #32148. It turns out the radar firmware still has to match the particular car. This is not a bug, but as a potential improvement, it would be reasonable to VIN fingerprint a MQB vehicle if it has radar firmware present in the union of all existing VW MQB vehicles. Same goes for VW PQ.
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
it would be reasonable to VIN fingerprint a MQB vehicle if it has radar firmware present in the union of all existing VW MQB vehicles
I'm fine with that. I think @adeebshihadeh wanted to double check the FW to ensure the brand from the VIN was correct(?), in which case we can assert the FW matches our expected FW pattern and/or check the gateway type which is one of 5 or so
I'm fine with that. I think @adeebshihadeh wanted to double check the FW to ensure the brand from the VIN was correct(?), in which case we can assert the FW matches our expected FW pattern and/or check the gateway type which is one of 5 or so
Looks like matching gateway types in the radar part number should make it pretty simple.
MQB: 2Q0, 3Q0, 5Q0 PQ: 561, 7N0
Remaining main part number 907567 or 907572, the one or two letter suffix can be ignored for this purpose.