openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

HKG: Add FW for 2022 Hyundai Tucson

Open jyoung8607 opened this issue 1 year ago • 3 comments

Car

2022 Hyundai Tucson, thanks to leycera!

Route

0c9d456c514da8d3/00000000--0171d6c582

jyoung8607 avatar Mar 14 '24 01:03 jyoung8607

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Mar 14 '24 01:03 github-actions[bot]

VIN check verifies this is a Tucson, but there's a unit test that very specifically blacklists this Tucson's camera firmware. What is it we're supposed to do here? @sshane @sunnyhaibin

image

jyoung8607 avatar Mar 14 '24 01:03 jyoung8607

This Tucson has the camera part number from a Santa Cruz, meaning that the steering tuning is likely a bit off. We're still waiting on merging the platforms since the platform code is the same (and therefore looks the same to us with some users' cars), @nuwandavek let me know if you can help check the lateral accel data.

TL;DR this is one case where the FW we get from the ECUs available isn't enough to detect the full API from the car, and we either need to learn it with torqued or detect it another way.

sshane avatar Mar 14 '24 02:03 sshane