openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

simulator: add bridge test

Open StefanLekanic-SYRMIA opened this issue 1 year ago • 8 comments

StefanLekanic-SYRMIA avatar Mar 07 '24 09:03 StefanLekanic-SYRMIA

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Mar 07 '24 09:03 github-actions[bot]

https://github.com/commaai/openpilot/actions/runs/8189680276/job/22394958743?pr=31759#step:7:474

looks like this succeeded but just timed out, probably a process was left running somehow?

jnewb1 avatar Mar 07 '24 22:03 jnewb1

https://github.com/commaai/openpilot/actions/runs/8189680276/job/22394958743?pr=31759#step:7:474

looks like this succeeded but just timed out, probably a process was left running somehow?

@jnewb1 It looks llike that to me too. I will try to repeat test, and try few more things...

StefanLekanic-SYRMIA avatar Mar 08 '24 09:03 StefanLekanic-SYRMIA

https://github.com/commaai/openpilot/actions/runs/8249381650

@jnewb1 I figured out that the problem with failing tests makes sm['controlsState'].active "flag" in if statement in line 67, of the test_sim_bridge file. Without this condition it works fine for 30, or 50 times.

StefanLekanic-SYRMIA avatar Mar 12 '24 13:03 StefanLekanic-SYRMIA

https://github.com/commaai/openpilot/actions/runs/8249381650

@jnewb1 I figured out that the problem with failing tests makes sm['controlsState'].active "flag" in if statement in line 67, of the test_sim_bridge file. Without this condition it works fine for 30, or 50 times.

that means that controlsd is not actually engaging, which can be seen in the logs

image

jnewb1 avatar Mar 12 '24 19:03 jnewb1

It passed 20 times.

StefanLekanic-SYRMIA avatar Mar 15 '24 14:03 StefanLekanic-SYRMIA

Something went wrong in the repo since friday, now all the tests are crashing all time.

StefanLekanic-SYRMIA avatar Mar 18 '24 14:03 StefanLekanic-SYRMIA

Something went wrong in the repo since friday, now all the tests are crashing all time.

https://github.com/commaai/openpilot/issues/31919

ah, due to pedal removal. will need to fix this

jnewb1 avatar Mar 19 '24 18:03 jnewb1