simulator: add bridge test
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
https://github.com/commaai/openpilot/actions/runs/8189680276/job/22394958743?pr=31759#step:7:474
looks like this succeeded but just timed out, probably a process was left running somehow?
https://github.com/commaai/openpilot/actions/runs/8189680276/job/22394958743?pr=31759#step:7:474
looks like this succeeded but just timed out, probably a process was left running somehow?
@jnewb1 It looks llike that to me too. I will try to repeat test, and try few more things...
https://github.com/commaai/openpilot/actions/runs/8249381650
@jnewb1 I figured out that the problem with failing tests makes sm['controlsState'].active "flag" in if statement in line 67, of the test_sim_bridge file. Without this condition it works fine for 30, or 50 times.
https://github.com/commaai/openpilot/actions/runs/8249381650
@jnewb1 I figured out that the problem with failing tests makes sm['controlsState'].active "flag" in if statement in line 67, of the test_sim_bridge file. Without this condition it works fine for 30, or 50 times.
that means that controlsd is not actually engaging, which can be seen in the logs
It passed 20 times.
Something went wrong in the repo since friday, now all the tests are crashing all time.
Something went wrong in the repo since friday, now all the tests are crashing all time.
https://github.com/commaai/openpilot/issues/31919
ah, due to pedal removal. will need to fix this