openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

honda: refactor minSteerSpeed params

Open csouers opened this issue 1 year ago • 2 comments
trafficstars

Description

  • Refactors the Honda minSteerSpeed params to mostly fit the new PlatformConfig style.
  • HONDA_CIVIC_BOSCH -- The min steer values are still defined within CarInfo as the minSteerSpeed can vary (2 mph or 12 mph) depending on the body style; 2/4 door vs 5 door. -- Sets the minSteerSpeed to 0 mph in interface when docs run to satisfy the CarInfo vs CarParam minSteerSpeed value check in docs.py. -- The minSteerSpeed param for openpilot is now set at 2 mph on this car; was previously 0.

TODO:

  • [ ] Generate and push reflogs
  • [ ] update ref commit

Verification

csouers avatar Feb 23 '24 04:02 csouers

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Mar 04 '24 22:03 github-actions[bot]

Leaving the TODO items undone for review. The two failed process_replay logs are for Honda Nidec and Bosch from setting the minSteerSpeed params.

csouers avatar Mar 21 '24 20:03 csouers