openpilot
openpilot copied to clipboard
honda: refactor minSteerSpeed params
trafficstars
Description
- Refactors the Honda minSteerSpeed params to mostly fit the new PlatformConfig style.
HONDA_CIVIC_BOSCH-- The min steer values are still defined within CarInfo as the minSteerSpeed can vary (2 mph or 12 mph) depending on the body style; 2/4 door vs 5 door. -- Sets the minSteerSpeed to 0 mph in interface when docs run to satisfy theCarInfo vs CarParamminSteerSpeed value check in docs.py. -- The minSteerSpeed param for openpilot is now set at 2 mph on this car; was previously 0.
TODO:
- [ ] Generate and push reflogs
- [ ] update ref commit
Verification
- Test suite?
- minSteerSpeed param print from test_car_interfaces.py
- docs.py yields no changes to CARS.md.
- No user facing changes as Honda doesn't have a low steer speed alert (yet)
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- the change is something we merge
- include a route or your device' dongle ID if relevant
Leaving the TODO items undone for review. The two failed process_replay logs are for Honda Nidec and Bosch from setting the minSteerSpeed params.