openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Subaru: FW query is inconsistent

Open sshane opened this issue 1 year ago • 3 comments

Brought to our attention from the FW bot, many Subarus return different results for the same ECU and request:

1c451e9ed3c48243|2024-01-15--16-10-38:
[('ecu', 'fwdCamera'), ('fwVersion', b'\x00\x00e\x9a\x00\x00\x00\x00\x00\x00'), ('address', 1927), ('subAddress', 0), ('responseAddress', 1935), ('request', [b'"\xf1\x82'])
vs
1c451e9ed3c48243|2024-01-15--20-36-22:
[('ecu', 'fwdCamera'), ('fwVersion', b'\x00\x00e\x9a\x00\x1f@ 1\x00'), ('address', 1927), ('subAddress', 0), ('responseAddress', 1935), ('request', [b'"\xf1\x82']) (edited) 

Race condition on startup?

Also looks like we've been adding them to the database:

    (Ecu.fwdCamera, 0x787, None): [
      b'\x00\x00df\x1f@ \n',
      b'\x00\x00d\x95\x00\x00\x00\x00',
      b'\x00\x00d\x95\x1f@ \x0f',
      b'\x00\x00d\xfe\x00\x00\x00\x00',

sshane avatar Jan 25 '24 01:01 sshane

Hi @EmilBuszylo, I have the same issue here ?

abdelkebir7Y avatar Jan 11 '24 17:01 abdelkebir7Y

I have a similar issue, in general the position is accurate but once in a while one point is a few hundred meters away from the real path. This seems to happen only on Android for me. It seems like a bug to me but I don't know if there is just a few Android devices that has a bad gps compared to iPhone.

alfredvaa avatar Jan 27 '24 06:01 alfredvaa

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] avatar Apr 26 '24 07:04 github-actions[bot]

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

github-actions[bot] avatar May 03 '24 08:05 github-actions[bot]