openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Published 20 hours ago • verified publisher icon commaai

[$100 bounty] Setup a PR review bot

Open adeebshihadeh opened this issue 1 year ago • 3 comments

To start, I'm thinking the bot's review just consists of checking that a template is filled out in the PR body.

  • keep PRs as drafts until the bot is done with its "review"
  • also add a special bot-review label while a PR is in the bot review phase
  • must run in GitHub Actions

Set this up on your own fork of openpilot, then make a PR here.

adeebshihadeh avatar Dec 13 '23 18:12 adeebshihadeh

Can you assign this to me please?

Also could you please provide the template that you want to check along with it?

mhardik003 avatar Dec 23 '23 19:12 mhardik003

heyy @adeebshihadeh is the issue still open ? I would like to contribute ?

bilalshaikh292 avatar Dec 23 '23 20:12 bilalshaikh292

Hey @adeebshihadeh , do you want any specific bot on this or anything that works?

hritikmunde avatar Dec 29 '23 21:12 hritikmunde

Hi @adeebshihadeh, I just looked into the two PRs that is open and thought to share the next,he first PR is using a Python script to solve the issue and the second one is using the Action compose feature which allows you to run a bash script to do the work you need.

Have you thought to use open source action tools that could simplify the issue and make it easier? I was thinking to use one of the next:

https://github.com/marketplace/actions/template-validator https://github.com/marketplace/actions/pr-description-checker

As for the label for bot review, I think just having a label at the end would be more logical since the bot review would take just a few seconds. WHat do you think?

I think my previous colleague @a0m0rajab could help and provide more insights as well.

umairjavaid avatar Jan 16 '24 21:01 umairjavaid