openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Cabana: Improve contrasts when using dark themes

Open projectgus opened this issue 2 years ago • 0 comments

Change some hard-coded colors in the Cabana UI that didn't always contrast well when using different system color themes:

  • Signal view text/value editor background
  • Signal log view heading text
  • Binaryview signal box color (when not selected or highlighted)
  • Chart title & message text

Before (automatic system theme with dark colors) before_automatic_dark_theme

Before (manually configured dark theme) before_manual_darktheme

After (automatic system theme with dark colors) after_automatic_dark

After (manually configured dark theme) after_manual_darktheme

I've only tested this on Linux, but I think it should produce either the same results on systems where the Base colour is White or improved contrast on other systems.

projectgus avatar Jun 03 '23 12:06 projectgus