openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Ford: brief unknown gear shifter position while driving

Open adeebshihadeh opened this issue 2 years ago • 3 comments

54827bf84c38b14f|2023-03-26--10-40-08--11

Briefly changed from "Drive" to "UnknownPosition", according to the DBC. May need to add some hysteresis.

image

adeebshihadeh avatar Mar 27 '23 23:03 adeebshihadeh

The message actually timed out for more than 0.5 seconds during this event as well (CAN parser waits for 1 second), it looks like there was some actual communication or sensor issue. The counter is also pretty flaky. Checking out the fleet data for this.

image

sshane avatar May 02 '23 04:05 sshane

Only saw this on our car, one other time in Feb, but not a lot of rlogs to go off of. The ECU timed out sending messages, so I'm not sure using hysteresis is the best way to handle this. canValid didn't fall only because the message timed out for 5x its normal rate, not 10x like we check for. It should be fine to merge Ford for now and check the fleet data once we have more users driving, but I'll also pull a few more rlogs from Azure to check in the mean time.

sshane avatar May 04 '23 05:05 sshane

Had the same alert again, believe it is the same issue 54827bf84c38b14f|2023-05-16--00-43-38--9 image

incognitojam avatar May 16 '23 08:05 incognitojam

@incognitojam I know we discussed switching to the more reliable message from the engine/transmission (it's one of those) instead of the flaky knob position message. Was there any issues with the engine/transmission message?

sshane avatar Aug 08 '23 02:08 sshane

From what I can remember the signal from the gear shifter was the one which didn't go to "neutral / no gear" when the transmission changed gear. If we change this I think the Lincoln also had some differences which we should check too.

incognitojam avatar Sep 09 '23 22:09 incognitojam

Fixed by https://github.com/commaai/openpilot/pull/32886

sshane avatar Jul 03 '24 05:07 sshane