openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

[$100 bounty] GM: get VIN

Open sshane opened this issue 2 years ago • 5 comments

You simply need to allow a different subset of addresses to send to in ELM mode (think 0x200 range?)

sshane avatar Jan 12 '23 06:01 sshane

Hi @sshane ,

Can I pick this challenge and if possible, can you point me the initial file where to begin as I am new to this project?

varshneydevansh avatar Aug 07 '23 07:08 varshneydevansh

I think this might have to do with getting VIN on GM: https://docs.google.com/spreadsheets/d/1qEwOXSr3bWoc2VUhpuIam236OOZxPc2hxpLUsV0xkn0/edit#gid=2 Row 162 and 163

leoforney avatar Nov 03 '23 17:11 leoforney

@leoforney Thank you so much. I will start working on this in December. Currently working on my writing thing. =)

varshneydevansh avatar Nov 05 '23 16:11 varshneydevansh

@sshane What's wrong with using VIN_part1 and VIN_part2 signals?

garrettpall avatar Jan 22 '24 23:01 garrettpall

Right now openpilot generates carParams once on startup, this requires a bit of a change to the architecture of openpilot. Doable, and we might want to do this since other cars also publish their VIN like this, but with the Bolt at least, we can just query the camera as the easiest way to get the VIN, right now.

sshane avatar Jan 23 '24 00:01 sshane

Done in https://github.com/commaai/openpilot/pull/31224

sshane avatar Jan 30 '24 07:01 sshane