openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Published 20 hours ago • verified publisher icon commaai

Added ControlsTimer class with example usage in mazda+hyundai

Open MoreTore opened this issue 2 years ago • 3 comments

Increase the readability of DT_CTRL based duration timers in carports. Also, remove redundant self.frame+=1 in every carcontroller. See examples for Mazda and Hyundai.

MoreTore avatar Dec 18 '22 19:12 MoreTore

Not sure why process replay is failing. The code should be good.

MoreTore avatar Dec 18 '22 20:12 MoreTore

I like the direction this is going in. Gonna move to draft until I have some time to look at it more.

adeebshihadeh avatar Feb 03 '23 01:02 adeebshihadeh

Let me know if you have any questions about it

MoreTore avatar Feb 08 '23 18:02 MoreTore

I added some unit tests in case you make changes

MoreTore avatar Apr 09 '23 07:04 MoreTore