commaai
WIP: Mazda gen 4 port
- [x] added entry to CarInfo in selfdrive/car/*/values.py and ran
selfdrive/car/docs.pyto generate new docs - [ ] support older mazda longitudinal control with radar intercept or unplug radar or just use radar points for OP learning stack.
- [ ] route with openpilot:
- [x] route with stock system: 164080f7933651c4|2022-12-01--16-19-34
- [ ] route with limit tests.
- [ ] update panda safety. https://github.com/commaai/panda/pull/1164
- [ ] update DBC file. https://github.com/commaai/opendbc/pull/749
- [ ] update cereal safetyModel or use safety param instead. https://github.com/commaai/cereal/pull/386
- [ ] test on Comma 3 device. Waiting for order delivery.
- [ ] test on multiple Mazda models
- [ ] find unique and consistent can ignition signal.
- [ ] use better initial tuning values and steering ratios
- [ ] Longitudinal tuning
Still need to get some harnesses out to people to get more drives uploaded. The new harness uses a different bus than what is currently on the Comma servers.
@sshane I added the opendbc bump to this PR. I'm not sure if that complicates things. Maybe you want it in a separate PR?
EDIT: After reviewing the comment you made I will open a separate PR.
Yes, bumping opendbc on this PR is appropriate. Can you try to merge --no-ff master into your PR? Force pushing makes it tough to review as you don't know what was changed, or if it was a simple rebase on master
Yes, bumping opendbc on this PR is appropriate. Can you try to merge --no-ff master into your PR? Force pushing makes it tough to review as you don't know what was changed, or if it was a simple rebase on master
Ah sorry too late. Already have the separate PR https://github.com/commaai/openpilot/pull/26608.
It would be a simple rebase.