openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Published 20 hours ago • verified publisher icon commaai

HKG: Resume from Standstill fix for HDA1 Canfd w/ 0x1cf

Open hoomoose opened this issue 2 years ago • 1 comments

Description Resume from Standstill does not work for HKG Can-FD cars with HDA1. This is fixed by putting the can send for Cruise Buttons on bus 6 rather than bus 5. The fix requires an IF statement, which I have not written since I am not sure how to do so. This fix only solves the problem for HDA1 cars with the 0x1cf signal like the EV6 and I5. Solves issue: https://github.com/commaai/openpilot/issues/25771

Prerequisite This requires a simple Panda change on L39 of safety_hyundai_canfd.h Bus 0 needs to be bus 2. That is it. see: https://github.com/commaai/panda/pull/1102

Verification This fix has been employed in a fork hoomoose:hda1ev6i5 written specifically for hda1 ev6 and I5 cars and has been successfully tested/used by many!

hoomoose avatar Oct 13 '22 16:10 hoomoose

Also interested in seeing this get merged!

mattwebbio avatar Oct 13 '22 17:10 mattwebbio

Current code works!

hoomoose avatar Oct 17 '22 22:10 hoomoose

Thanks for all the work on HDA1 @hoomoose!

adeebshihadeh avatar Oct 19 '22 22:10 adeebshihadeh