openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Genesis GV70 2022 port

Open zunichky opened this issue 3 years ago • 1 comments

GV70 Car port

Checklist

  • [x] added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • [x] test route added to routes.py
  • [x] route with openpilot: ca4de5b12321bd98|2022-08-22--20-23-34
  • [x] route with stock system: ca4de5b12321bd98|2022-08-22--20-20-29

** Previous PR was #25140. Got too far away from master so easier to create new PR.

TODOs

  • [ ] Fix _COUNTER for CRUISE_BUTTON
  • [ ] Fix panda - wait until we figure out this code first
  • [ ] Attempt to merge gv70 specific dbc file with generic canfd

GV70 Differences

  1. Gas/Brake: Are both on ACCELERATOR_ALT GV70: ret.gasPressed = cp.vl["ACCELERATOR_ALT"]["ACCELERATOR_PEDAL_PRESSED"] == 1 ret.brakePressed = cp.vl["ACCELERATOR_ALT"]["BRAKE_PRESSED"] == 1 Normal HDA: ret.gasPressed = ret.gas > 1e-5 ret.brakePressed = cp.vl["BRAKE"]["BRAKE_PRESSED"] == 1

  2. CRUISE_BUTTON: need to use _COUNTER GV70: Checksum: 8 bits Counter: 4 bits Normal: Checksum: 16 Counter: 8

  3. CRUISE_BUTTONS is on bus 4, not 5

  4. get_can_parser_canfd signals are on bus 4 not 6

zunichky avatar Oct 13 '22 15:10 zunichky

@adeebshihadeh I created a new PR as my other branch got too far away from master.

zunichky avatar Oct 13 '22 15:10 zunichky

closing this PR, moving to #25434

zunichky avatar Oct 18 '22 00:10 zunichky