openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Recover from blocked steering messages

Open sshane opened this issue 3 years ago • 3 comments

To recover from blocked messages, think we can do this incrementally

sshane avatar Oct 09 '22 19:10 sshane

We can certainly do this incrementally, but I'd really like to do this generically from the start. This is a problem with all ports, and it'll quickly get out of hand if we do it like this for all of them.

adeebshihadeh avatar Oct 09 '22 19:10 adeebshihadeh

proof of concept, but did you mean something like this where controlsd passes in all blocked addrs?

sshane avatar Oct 09 '22 20:10 sshane

This is a big change, but perhaps we should break apart generating the car specific state and sending CAN messages at specific frequencies. Like have carcontroller generate the complete car specific state at a high frequency and something else manage outputting the CAN messages each at the appropriate frequency (e.g. register functions with associated frequencies). Then we can detect blocked messages and immediately send a new message generically as fast as possible. We could probably find a way to do it one car at a time if we thought it was a good long-term abstraction.

gregjhogan avatar Oct 10 '22 04:10 gregjhogan

will come up with something final and re-open

sshane avatar Nov 29 '22 10:11 sshane