openpilot
openpilot copied to clipboard
commaai
HKG: Add FW and Remove from dashcamOnly for 2019 Elantra GT i30
Add firmware for the 2019 Hyundai Elantra GT i30. Remove the platform from the dashcamOnly flag.
Route ID: 734ef96182ddf940|2022-10-02--16-41-44
Thanks to community Elantra GT i30 owner [Bread Jar Mang#1222] (Discord).
@sshane this comment says it's the same as the Elantra. any reason why it has a different openpilot platform? also looks like it does indeed deserve a new CarInfo line since it's marketed as the "Hyundai i30"
Not that I'm aware of, this was before my time. I'll have a look at merging them soon with a separate CarInfo entry
Do you know what harness this user's car uses? I don't see it in any of our old databases
This is actually the same platform as the Ceed with the same harness. Should we tend to combine these cases into single platforms (with two CarInfos) @adeebshihadeh?
https://en.wikipedia.org/wiki/Hyundai_i30
This is actually the same platform as the Ceed with the same harness. Should we tend to combine these cases into single platforms (with two CarInfos) @adeebshihadeh?
https://en.wikipedia.org/wiki/Hyundai_i30
Yes, if they're the same as far as openpilot is concerned.
So these two marketed cars (i30 and Elantra GT) have SCC with stop and go, whereas the Elantra 2019 does not. And the transmission signal is slightly different than the Ceed, so we can't combine it there. Going to keep it separate as it's relatively different enough unless we're fine with not being able to enforce the minimum enable speed one day (right now only in CarInfo)
Let's test longitudinal first too, this car wasn't in legacy safety mode cars before
Let's test longitudinal first too, this car wasn't in legacy safety mode cars before
@sshane Requested the user to test and will report back when tested.
Feel free to open a PR to remove from legacy safety mode if you confirm longitudinal works