openpilot
openpilot copied to clipboard
commaai
Ram: ProMaster support
Hi Castle Hill, Below is a PR to include the new Promaster firmware versions and fingerprint.
@realfast is this van the same platform as the trucks?
Seems to be a Fiat Ducato platform, doubt it's shared with trucks.
@realfast is this van the same platform as the trucks?
This is Fiat Ducato based as @GregorKikelj pointed out.
@jande48 Were you doing the full port? This just adds FW versions, and it's a different platform as Gregor points out. It looks like you accidentally opened this to commaai/openpilot instead of a fork, can we close if this isn't going to be the full port?
Correct. Is this still an Open PR? I’ll take it down. Sorry, it’s not ready for review
On Thu, Oct 27, 2022 at 6:53 PM Shane Smiskol @.***> wrote:
@jande48 https://github.com/jande48 Were you doing the full port? This just adds FW versions, and it's a different platform as Gregor points out. It looks like you accidentally opened this to commaai/openpilot, not a fork?
— Reply to this email directly, view it on GitHub https://github.com/commaai/openpilot/pull/25846#issuecomment-1294243092, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMVMJQU7UBCTDHKJRO55T3WFMIXHANCNFSM6AAAAAAQQQHAPA . You are receiving this because you were mentioned.Message ID: @.***>
no problem, feel free to re-open when you start working on this or for any help!
I'm interested in getting OP to work with promaster, but I want to make sure I'm getting the right Promaster. From the work that's been done so far, does anyone know if I need a promaster with LKAS to be able to control the EPS? Or would a normal 2022 model (with EPS) + ACC also be capable to execute lateral controls?
