openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Wi-Fi networks with WPA3 are not supported

Open MarcoTheDingo opened this issue 3 years ago • 6 comments

Wi-Fi networks using only the WPA3 security protocol are showing the 🚫 symbol next to them, and cannot be joined.

  • The Qualcomm 845 does seem to support WPA3 at a hardware level. (Source: XDA Developers)
  • Discord user nelsonjchen said the missing Security Flag might be "NM_802_11_AP_SEC_KEY_MGMT_SAE". (Link to post)

See the network "DingoAteYourBaby" in the attached screenshot, which is only using WPA3. The IOT network current connected, has the exact same settings, on the same Access Point, except it is using WPA2. Comma_WPA3

MarcoTheDingo avatar Sep 12 '22 04:09 MarcoTheDingo

https://github.com/commaai/openpilot/blob/f6398ea7864779f621f84df65ded7ee083e72c09/selfdrive/ui/qt/offroad/wifiManager.cc#L147-L149

Probably just needs an extra flag added here.

I would also say this issue probably only applies to networks with WPA3 only.

nelsonjchen avatar Sep 12 '22 17:09 nelsonjchen

Great, want to open a PR and test it?

adeebshihadeh avatar Sep 12 '22 17:09 adeebshihadeh

I am by no means a developer, but I did fork and add the flag in both networkmanager.h & wifiManager.cc. https://github.com/TheOfficialJosh/openpilot/tree/wifi-wpa3

It sees the network and allows me to type in the password, but it does not actually connect.

Accidentally closed this

MarcoTheDingo avatar Sep 12 '22 19:09 MarcoTheDingo

Tested with two different Wi-Fi networks using only WPA3. It only saves the password, but never connects. Going to guess there's something more than these two lines.

Is there a log file I can provide to help with figuring it out?

MarcoTheDingo avatar Sep 12 '22 23:09 MarcoTheDingo

I can replicate this on my comma three, and looking at the system logs doesn't give much information. I think we might just have to update the network manager package, which is already on the latest release available in apt for Ubuntu 20.04/agnos...

EDIT: If anyone wants to try and solve this I expect you'll need to temporarily add the jammy (22.04) package list to apt sources and upgrading network manager (remount / as rw and ro again after, and be warned upgrading any package might break your agnos! just try upgrading network manager alone)

incognitojam avatar Sep 13 '22 00:09 incognitojam

We build ModemManager from source, might have to do the same for NetworkManager.

adeebshihadeh avatar Sep 13 '22 23:09 adeebshihadeh